TripleliftBidAdapter - remove dependency on getTopWindowLocation util #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
reviewed
Sep 28, 2018
| if (bidderRequest && bidderRequest.refererInfo) { | ||
| let referrer = bidderRequest.refererInfo.referer; | ||
| tlCall = utils.tryAppendQueryString(tlCall, 'referrer', referrer); | ||
| } |
There was a problem hiding this comment.
Looks good but should add a unit test.
|
@brittanyzellman any update here? |
|
@harpere Sorry I have had to deprioritize writing a new unit test for this (I can't just add this to the existing test) since the start of Q4. I will hopefully get to it within the next week or two. Is there a date that these methods will be removed? I didnt see it in the issue. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@harpere - please review the new unit tests |
idettman
approved these changes
Nov 7, 2018
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…prebid#3139) * removed dependancy on getTopWindowUrl for referer * protect against undefined obj and remove test on old dependency * added unit test for referer and gdpr in query string * removed gdpr test * removed gdpr from bidderRequest obj * decontructed bidder request obj in chai test * just need to run karma tests again * added gdpr consent to all bidderRequest obj in chai tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Due to util.getTopWindowLocation being deprecated, I updated the adapter to use bidderRequest.refererInfo instead.
Other information
@jaiminpanchal27 @jsnellbaker
issue